mapbox-vision-ios icon indicating copy to clipboard operation
mapbox-vision-ios copied to clipboard

Vision SDK should notify delegate when replay video finishes

Open avi-c opened this issue 6 years ago • 4 comments

Description

VisionReplayManager does not notify the delegate when replay finishes. This presents a problem for the delegate since it will not know if the replay manager state is start or stop.

For example, if I am using the replay manager to replay a nav session in Apex, I need to stop the replay manager if the user hits the "end" button. However, if the replay runs all the way through to the end before the user hits End, then if I try to stop the replay then I will crash since the replay manager throws an exception if the replay manager is told to stop when it is not playing.

avi-c avatar Sep 17 '19 22:09 avi-c

Thanks for the report @avi-c

vladzima avatar Sep 17 '19 22:09 vladzima

Without this knowledge, I won't know if it's safe to call stop() on the replay manager or if calling it will lead to a crash.

avi-c avatar Sep 17 '19 22:09 avi-c

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] avatar Nov 01 '19 23:11 stale[bot]

Is this still valid? :)

vladzima avatar Jul 19 '20 00:07 vladzima