mapbox-unity-sdk icon indicating copy to clipboard operation
mapbox-unity-sdk copied to clipboard
verified publisher icon mapbox

Updated to new ARKit (Fixes compilation issues for non IOS devices)

Open devedse opened this issue 6 years ago • 2 comments

Related issue

Fixes #1459

Description of changes

  • Updated ARKit to the latest version
  • Updated to the latest 2017 unity version

QA checklists

  • [N/A] Add relevant code comments. Every API class and method should have <summary> description as well as description of parameters.
  • [N/A] Add tests for new/changed/updated classes and methods!!!
  • [N/A] Check out conventions in CONTRIBUTING.md.
  • [N/A] Check out conventions in CODING-STYLE.md
  • [TODO] Update the changelog
  • [TODO] Update documentation.

Reviewers

Todo

There's some items that have to be done before this should be merged:

  1. Review (Main question I have is, if this should be completely compiler excluded for non IOS devices): https://github.com/devedse/mapbox-unity-sdk/blob/develop/sdkproject/Assets/UnityARInterface/Scripts/ARKitInterface.cs
  2. Check if there's any need for additional documentation / dependencies

devedse avatar Sep 14 '19 15:09 devedse

@Guardiola31337 , trying to get some attention to this PR :smile:. Is this something that could be merged?

devedse avatar Oct 16 '19 11:10 devedse

Is there any solution after all? Can we build on android platform? Please I try 2 weeks to find a solution.

iliasmour avatar Feb 17 '22 15:02 iliasmour