mapbox-navigation-ios icon indicating copy to clipboard operation
mapbox-navigation-ios copied to clipboard

Migrate breaking changes detector to swift-api-digester

Open S2Ler opened this issue 3 years ago • 2 comments

Now

We detect breaking changes by building an abstract syntax tree from the source code using "SourceKit" and then building the diff and then analysing what is considered a breaking change.

Proposed

Use swift-api-digester tool that ships with Xcode to detect breaking API changes.

Why

Instead of maintaining the own tool, we will use a tool that is maintained by compiler engineers that will have less false positives that we currently have.

S2Ler avatar Apr 15 '22 10:04 S2Ler

@S2Ler, can you please provide more details on this one? Is it for internal application usage?

MaximAlien avatar May 02 '22 17:05 MaximAlien

This is for SDK similar to what Maps SDK team built. https://github.com/mapbox/mapbox-maps-ios/blob/main/scripts/api-compatibility-check/breaking-api-check.py

S2Ler avatar Dec 14 '22 06:12 S2Ler