mapbox-navigation-ios icon indicating copy to clipboard operation
mapbox-navigation-ios copied to clipboard
verified publisher icon mapbox

Make EndOfRouteViewController public and reusable

Open 1ec5 opened this issue 4 years ago • 1 comments

EndOfRouteViewController is a private class. We should expose it publicly and make it more reusable, similar to FeedbackViewController, so that the application can more easily solicit feedback about a trip after ending the trip. As it is, the user must complete the trip in order to access this view controller, but if they quit the application or it crashes, there’s no way for the user to explain why. This is somewhat a platform parity issue, because the Android navigation SDK apparently decouples feedback events from arrival events, which is what would probably need to happen when making EndOfRouteViewController reusable in this way.

/cc @mapbox/navigation-ios

1ec5 avatar Sep 30 '21 19:09 1ec5

There is this draft where I tried to address this issue. PR wasn't refreshed for some time now, but it still illustrates the ideas and approach. This could be a starting point.

Udumft avatar Oct 01 '21 08:10 Udumft