mapbox-navigation-ios icon indicating copy to clipboard operation
mapbox-navigation-ios copied to clipboard

Voice navigation says "drive" for walking route (in German)

Open imaginaris opened this issue 6 years ago • 6 comments

Mapbox Navigation SDK version: 0.35.0

For apps with German language voice navigation says "drive" even if route profile is set for walking (route path itself is ok). I'm not sure if it applies to other languages as well. English commands seem to be route-type agnostic

imaginaris avatar Aug 06 '19 09:08 imaginaris

Thank you for reporting this issue. Translations of the voice instruction text are managed at Transifex. If you happen to know German, we welcome corrections there.

1ec5 avatar Aug 07 '19 04:08 1ec5

You seem to be using the same voice commands for people driving and people walking. You must differentiate for German users between these two use cases and use proper language to direct the user. Otherwise, your solution will be confusing.

imaginaris avatar Aug 07 '19 09:08 imaginaris

Is there a more general way of phrasing the instructions so that it doesn’t imply a particular mode of transportation?

1ec5 avatar Aug 12 '19 21:08 1ec5

cc: @dgearhart

andrlee avatar Aug 23 '19 20:08 andrlee

If it helps - here are the Valhalla start/first maneuver phrases in English and German

//#############################################################################
//### en-US
    "start": {
      "phrases": {
        "0": "Head <CARDINAL_DIRECTION>.",
        "1": "Head <CARDINAL_DIRECTION> on <STREET_NAMES>.",
        "2": "Head <CARDINAL_DIRECTION> on <BEGIN_STREET_NAMES>. Continue on <STREET_NAMES>.",
        "4": "Drive <CARDINAL_DIRECTION>.",
        "5": "Drive <CARDINAL_DIRECTION> on <STREET_NAMES>.",
        "6": "Drive <CARDINAL_DIRECTION> on <BEGIN_STREET_NAMES>. Continue on <STREET_NAMES>.",
        "8": "Walk <CARDINAL_DIRECTION>.",
        "9": "Walk <CARDINAL_DIRECTION> on <STREET_NAMES>.",
        "10": "Walk <CARDINAL_DIRECTION> on <BEGIN_STREET_NAMES>. Continue on <STREET_NAMES>.",
        "16": "Bike <CARDINAL_DIRECTION>.",
        "17": "Bike <CARDINAL_DIRECTION> on <STREET_NAMES>.",
        "18": "Bike <CARDINAL_DIRECTION> on <BEGIN_STREET_NAMES>. Continue on <STREET_NAMES>."
      },
    }

//#############################################################################
//### de-DE
    "start": {
      "phrases": {
        "0": "Richtung <CARDINAL_DIRECTION>.",
        "1": "Auf <STREET_NAMES> Richtung <CARDINAL_DIRECTION>.",
        "2": "Auf <BEGIN_STREET_NAMES> Richtung <CARDINAL_DIRECTION>. Dann weiter auf <STREET_NAMES>.",
        "4": "Richtung <CARDINAL_DIRECTION> fahren.",
        "5": "Auf <STREET_NAMES> Richtung <CARDINAL_DIRECTION> fahren.",
        "6": "Auf <BEGIN_STREET_NAMES> Richtung <CARDINAL_DIRECTION> fahren. Dann weiter auf <STREET_NAMES>.",
        "8": "Richtung <CARDINAL_DIRECTION> laufen.",
        "9": "Auf <STREET_NAMES> Richtung <CARDINAL_DIRECTION> laufen.",
        "10": "Auf <BEGIN_STREET_NAMES> Richtung <CARDINAL_DIRECTION> laufen. Dann weiter auf <STREET_NAMES>.",
        "16": "Richtung <CARDINAL_DIRECTION> radeln.",
        "17": "Auf <STREET_NAMES> Richtung <CARDINAL_DIRECTION> radeln.",
        "18": "Auf <BEGIN_STREET_NAMES> Richtung <CARDINAL_DIRECTION> radeln. Dann weiter auf <STREET_NAMES>."
      },
    }

cc: @kevinkreiser

dgearhart avatar Aug 26 '19 12:08 dgearhart

The Directions API’s walking profile is now powered by Valhalla, so the original reported issue is no longer an issue. The cycling profile continues to use OSRM for the time being, so technically the issue is still present.

1ec5 avatar Oct 04 '21 06:10 1ec5