mapbox-maps-android
mapbox-maps-android copied to clipboard
revert setCamera exception fix #652
Summary of changes
- After gl-native bump to v10.8.0-rc.1, exceptions in set camera will be handled in native, which makes the fix in https://github.com/mapbox/mapbox-maps-android/pull/652 redundant. Reverting old fix in this pr.
More context can be found in MAPSAND-389.
User impact (optional)
Pull request checklist:
- [ ] Briefly describe the changes in this PR.
- [ ] Include before/after visuals or gifs if this PR includes visual changes.
- [ ] Write tests for all new functionality. If tests were not written, please explain why.
- [ ] Optimize code for java consumption (
@JvmOverloads,@file:JvmName, etc). - [ ] Add example if relevant.
- [ ] Document any changes to public APIs.
- [ ] Run
make update-apito update generated api files, if there's public API changes, otherwise theverify-api-*CI steps might fail. - [ ] Update CHANGELOG.md or use the label 'skip changelog', otherwise
check changelogCI step will fail. - [x] If this PR is a
v10.9release branch fix / enhancement, merge it tomainfirstly and then port tov10.9release branch.
Fixes: < Link to related issues that will be fixed by this pull request, if they exist >
PRs must be submitted under the terms of our Contributor License Agreement CLA.
will add changelog once https://github.com/mapbox/mapbox-maps-android/pull/1623 is merged.
As discussed offline, this pr will be merged with v10.9-beta.1
we are keeping catching Exceptions as it is as native catches java.lang.error and not java.lang.exception.