mapbox-maps-android icon indicating copy to clipboard operation
mapbox-maps-android copied to clipboard

revert setCamera exception fix #652

Open ank27 opened this issue 3 years ago • 1 comments

Summary of changes

  • After gl-native bump to v10.8.0-rc.1, exceptions in set camera will be handled in native, which makes the fix in https://github.com/mapbox/mapbox-maps-android/pull/652 redundant. Reverting old fix in this pr.

More context can be found in MAPSAND-389.

User impact (optional)

Pull request checklist:

  • [ ] Briefly describe the changes in this PR.
  • [ ] Include before/after visuals or gifs if this PR includes visual changes.
  • [ ] Write tests for all new functionality. If tests were not written, please explain why.
  • [ ] Optimize code for java consumption (@JvmOverloads, @file:JvmName, etc).
  • [ ] Add example if relevant.
  • [ ] Document any changes to public APIs.
  • [ ] Run make update-api to update generated api files, if there's public API changes, otherwise the verify-api-* CI steps might fail.
  • [ ] Update CHANGELOG.md or use the label 'skip changelog', otherwise check changelog CI step will fail.
  • [x] If this PR is a v10.9 release branch fix / enhancement, merge it to main firstly and then port to v10.9 release branch.

Fixes: < Link to related issues that will be fixed by this pull request, if they exist >

PRs must be submitted under the terms of our Contributor License Agreement CLA.

ank27 avatar Aug 24 '22 10:08 ank27

will add changelog once https://github.com/mapbox/mapbox-maps-android/pull/1623 is merged.

ank27 avatar Aug 24 '22 10:08 ank27

As discussed offline, this pr will be merged with v10.9-beta.1

ank27 avatar Aug 29 '22 10:08 ank27

we are keeping catching Exceptions as it is as native catches java.lang.error and not java.lang.exception.

ank27 avatar Sep 15 '22 11:09 ank27