mapbox-maps-android icon indicating copy to clipboard operation
mapbox-maps-android copied to clipboard
verified publisher icon mapbox

bump gradle to 7.5.1

Open alexander-kulikovskii opened this issue 3 years ago • 3 comments

Summary of changes

Update gradle version to 7.5.1. Also it's unblock us in using new dependency system.

User impact (optional)

Pull request checklist:

  • [ ] Briefly describe the changes in this PR.
  • [ ] Include before/after visuals or gifs if this PR includes visual changes.
  • [ ] Write tests for all new functionality. If tests were not written, please explain why.
  • [ ] Optimize code for java consumption (@JvmOverloads, @file:JvmName, etc).
  • [ ] Add example if relevant.
  • [ ] Document any changes to public APIs.
  • [ ] Run make update-api to update generated api files, if there's public API changes, otherwise the verify-api-* CI steps might fail.
  • [ ] Update CHANGELOG.md or use the label 'skip changelog', otherwise check changelog CI step will fail.
  • [ ] If this PR is a v10.[version] release branch fix / enhancement, merge it to main firstly and then port to v10.[version] release branch.

Fixes: < Link to related issues that will be fixed by this pull request, if they exist >

PRs must be submitted under the terms of our Contributor License Agreement CLA.

alexander-kulikovskii avatar Aug 18 '22 13:08 alexander-kulikovskii

Can you please add PR description? Are we updating gradle to unblock some things?

done

alexander-kulikovskii avatar Oct 20 '22 07:10 alexander-kulikovskii

new dependency system.

Not sure, what dependency system is meant?

yunikkk avatar Oct 20 '22 09:10 yunikkk

new dependency system.

Not sure, what dependency system is meant?

https://proandroiddev.com/gradle-version-catalogs-for-an-awesome-dependency-management-f2ba700ff894

advantages I can highlight:

  • convenience of importing a large dependency list as one line
  • ability to share library versions between teams

alexander-kulikovskii avatar Oct 20 '22 09:10 alexander-kulikovskii

Have the Gradle custom plugins been tested? (e.g. SDK Registry one)

jush avatar Dec 08 '22 09:12 jush

Have the Gradle custom plugins been tested? (e.g. SDK Registry one)

sure https://github.com/mapbox/mapbox-android-gradle-plugins/pull/83

alexander-kulikovskii avatar Dec 08 '22 10:12 alexander-kulikovskii