add toll cost parameter

[dzinad]

[codecov[bot]]

Codecov Report

Merging #1458 (33975ac) into main (7432118) will increase coverage by 0.14%. The diff coverage is 100.00%.

:exclamation: Current head 33975ac differs from pull request most recent head dce4652. Consider uploading reports for the commit dce4652 to get more accurate results

@@             Coverage Diff              @@
##               main    #1458      +/-   ##
============================================
+ Coverage     76.38%   76.53%   +0.14%     
- Complexity      896      908      +12     
============================================
  Files           125      128       +3     
  Lines          3905     3929      +24     
  Branches        568      568              
============================================
+ Hits           2983     3007      +24     
  Misses          675      675              
  Partials        247      247              

Impacted Files	Coverage Δ
...pbox/api/directions/v5/models/DirectionsRoute.java	100.00% <ø> (ø)
...x/api/directions/v5/models/CostPerVehicleSize.java	100.00% <100.00%> (ø)
...apbox/api/directions/v5/models/PaymentMethods.java	100.00% <100.00%> (ø)
.../mapbox/api/directions/v5/models/RouteOptions.java	95.02% <100.00%> (+0.02%)	:arrow_up:
.../com/mapbox/api/directions/v5/models/TollCost.java	100.00% <100.00%> (ø)
...com/mapbox/api/directions/v5/MapboxDirections.java	89.43% <100.00%> (+0.17%)	:arrow_up:
.../com/mapbox/api/directions/v5/models/RestStop.java	100.00% <0.00%> (ø)
...box/api/directions/v5/models/BannerComponents.java	100.00% <0.00%> (ø)

[RingerJK]

reopen: PR is relevant

[dzinad]

How do I test that it works? I mean the integration part. @mapbox/navigation-android

[VysotskiVadim]

How do I test that it works? I mean the integration part. @mapbox/navigation-android

I usually modify and run com.mapbox.samples.BasicDirections#main

[VysotskiVadim]

@dzinad , please do not forget to add the new request parameter to DirectionsService, I forgot to remind you during review 🙂

[dzinad]

@dzinad , please do not forget to add the new request parameter to DirectionsService, I forgot to remind you during review 🙂

Done, thanks!

[zugaldia]

@RingerJK @dzinad What's next for this PR to land?

[RingerJK]

@LukasPaczos proposed not to merge the PR, as the API is not public and it is against what we decided (expose via mapbox-java public API only). @LukasPaczos could you correct me if I missed something

[dzinad]

@RingerJK @dzinad What's next for this PR to land?

Also there's a bug that's being fixed, so I need that to land in order to test my code.

[LukasPaczos]

@LukasPaczos proposed not to merge the PR, as the API is not public and it is against what we decided (expose via mapbox-java public API only)

That's correct. Since we are waiting for the bug to be resolved anyway, we can wait for the team's review on the API exposure guide. If anything changes in the interim, we can sync and decide separately.