mapbox-directions-swift icon indicating copy to clipboard operation
mapbox-directions-swift copied to clipboard

Osrm support

Open RomainQuidet opened this issue 8 years ago • 7 comments

I just updated the directions init to really support any custom host. This allows us to use any OSRM server.

RomainQuidet avatar Oct 27 '17 14:10 RomainQuidet

this is for issue #121

RomainQuidet avatar Oct 27 '17 14:10 RomainQuidet

any clue why bitrise fails ? It compiles on Xcode 9.1 / swift 3.2

RomainQuidet avatar Nov 03 '17 14:11 RomainQuidet

It looks like requests are still being made with a Mapbox access token (or it's expecting one to be there):

Selected tests
Test Suite MapboxDirectionsTests.xctest started
V4Tests
    ✗ testPolyline, XCTAssertNil failed: "Error Domain=MBDirectionsErrorDomain Code=-1 "Not Authorized - Invalid Token" UserInfo={NSLocalizedFailureReason=Not Authorized - Invalid Token}" - Error: Error Domain=MBDirectionsErrorDomain Code=-1 "Not Authorized - Invalid Token" UserInfo={NSLocalizedFailureReason=Not Authorized - Invalid Token}
    ✗ testPolyline, XCTAssertNotNil failed -
❌  fatal error: unexpectedly found nil while unwrapping an Optional value

bsudekum avatar Nov 03 '17 14:11 bsudekum

Ha yes sorry I need to check the unit tests ! Thanks.

RomainQuidet avatar Nov 03 '17 14:11 RomainQuidet

@bsudekum Hi, how can we move forward with this pull request ? Do I have to change something ?

RomainQuidet avatar Nov 10 '17 13:11 RomainQuidet

Also cc @1ec5

bsudekum avatar Nov 10 '17 14:11 bsudekum

What's the status of this?

datwelk avatar Dec 11 '18 12:12 datwelk