api2go icon indicating copy to clipboard operation
api2go copied to clipboard

Adding RouteNamer interface

Open mikeschinkel opened this issue 6 years ago • 3 comments

Using api2go I noticed you coupled the types with the route names, and I want to have singular types and plural routes. So I added a RouteNamer interface. If you are willing to accept this I will be happy to update the docs too.

mikeschinkel avatar Mar 24 '19 03:03 mikeschinkel

Thanks, LGTM but before we merge we should get the tests back to be running. I will look into this, merge it in and then you can rebase on master.

wwwdata avatar Mar 24 '19 16:03 wwwdata

Ok, fixed the build problems in PR #325

What you could also do is add a small test to check that this functionality works so that we can guarantee that nothing breaks it in the future. Then we rebase after merging my PR and can merge this.

wwwdata avatar Mar 24 '19 17:03 wwwdata

@mikeschinkel ping: would you like to continue here? otherwise I can also take over and merge after adding tests

wwwdata avatar May 06 '19 06:05 wwwdata