pacparser icon indicating copy to clipboard operation
pacparser copied to clipboard

Enhancements to build a static pacparser library and static pactester executable

Open mzpqnxow opened this issue 4 years ago • 3 comments

This was requested as a feature a while back in #28 and was declined with a reasonable explanation

I understand you may prefer to decline this PR but I figured there was a chance you would accept it since it doesn't require any extra effort on your part (well, not entirely true- you would have to "support" it, to some extent)

Either way, it's not important to me if you accept it. By having it here it will be documented for anyone who needs it, like the individual who opened up #28. I'm happy to save someone some time who may have the same unusual use-case as me :)

Thanks for the work you do on this project. Without it, I would have some really irritating problems to solve on production systems

mzpqnxow avatar Sep 05 '21 17:09 mzpqnxow

@manugarg any interest in accepting this one? I added it because I needed a statically linked CNTLM executable. For that reason I pushed a static linking PR to one of the CNTLM forks and then used this patch as I needed PAC parsing in CNTLM

Thanks!

mzpqnxow avatar Oct 17 '21 15:10 mzpqnxow

The current PR seems to contain multiple things and I am not sure if the individual commits in it are really independent. If it would be merged as-is, that would make bisects less convenient for instance. I guess a rebased PR and possibly separate PRs for independent changes would make this more attractive to merge.

jschwartzenberg avatar Oct 17 '21 20:10 jschwartzenberg

The current PR seems to contain multiple things and I am not sure if the individual commits in it are really independent. If it would be merged as-is, that would make bisects less convenient for instance. I guess a rebased PR and possibly separate PRs for independent changes would make this more attractive to merge.

jschwartzenberg avatar Oct 17 '21 20:10 jschwartzenberg