ui.mantine.dev icon indicating copy to clipboard operation
ui.mantine.dev copied to clipboard

Make 2nd layer links optional in Menu components

Open Ymirke opened this issue 3 years ago • 4 comments

Currently you get TS error if you don't supply links argument to menu links.

If you supply empty array you get a dropdown with the link item, and the dropdown is empty.

Same TS issue might apply to other menu components as well.

Ymirke avatar Mar 29 '22 07:03 Ymirke

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

ui-mantine-dev – ./

🔍 Inspect: https://vercel.com/rtivital/ui-mantine-dev/5SPMcjqindSLiXFhKSA95ee2uYHm
✅ Preview: https://ui-mantine-dev-git-fork-ymirke-patch-1-rtivital.vercel.app

vercel[bot] avatar Mar 29 '22 07:03 vercel[bot]

Deployment failed with the following error:

The most recent charge for your active payment method has failed. Please update it here: https://vercel.com/teams/mantinedev/settings/billing.

vercel[bot] avatar Mar 29 '22 07:03 vercel[bot]

This is also applicable to HeaderAction and HeaderMenuColored which would benefit from specifying nullability on sub-links.

russellbanks avatar Mar 30 '22 20:03 russellbanks

Deploy Preview for zesty-dragon-10e479 ready!

Name Link
Latest commit 790797a54be7759ef98cb7334a8c4b688ef6e516
Latest deploy log https://app.netlify.com/sites/zesty-dragon-10e479/deploys/6246b96e5275270008e2139d
Deploy Preview https://deploy-preview-6--zesty-dragon-10e479.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Apr 01 '22 08:04 netlify[bot]