hn-android Chrome custom tabs

Open links in Chrome custom tabs (if available), falling back to webview.

Aug 14 '16 15:08 0xKD

Thank you. I just released a fix for the comments parsing and will try to take a look at your PR by the end of the week.

Aug 16 '16 09:08 peshkira

@0xKD This is great, but there is no way to switch between the article and the comments when using the Chrome Tabs. Unfortunately, I don't have much experience with Chrome Tabs for now. Do you know, if there is any way to customise the toolbar of the chrome tab (I will have to research this myself as well)?

If there isn't, then we have to make it a setting and let the user choose, if they want to open the Articles, via a ChromeTab, Webview in the App or the system browser?

Would you be interested in making this improvement in the SettingsActivity before we can merge this?

Thanks!

Aug 24 '16 08:08 peshkira

There is a way to switch to the article from the comments but not the other way round. This can be added using a custom action button, and is something I tried, but there is no clean way (or I couldn't figure out one) to go back to the list of posts (something that is currently done using finish(), instead of the article comments), when one goes from Comments -> Article and then hits the back button.

Aug 24 '16 08:08 0xKD

Ok, I will try to have a look this weekend, if there is a way to customise the toolbar or how to add an action button. Any help and/or info is greatly appreciated.

For now we could make it a setting and let people choose performance over ease of use.

Aug 24 '16 08:08 peshkira

I've made this a preference in the settings screen and added a button which takes you to the comments from the article (demo video)

Aug 28 '16 12:08 0xKD

That looks awesome. Thank you very much! I'll try to merge and publish it today.

Aug 29 '16 07:08 peshkira