temporal-clojure-sdk icon indicating copy to clipboard operation
temporal-clojure-sdk copied to clipboard

Use temporal-shaded to avoid protobuf version mismatch

Open FelipeCortez opened this issue 3 months ago • 3 comments

The cljdoc API import seems to have been failing since 1.3.0 because of a protobuf version mismatch. This PR switches the Temporal Java SDK to the shaded version. Analysis was tested locally with clojure -Ttools install io.github.cljdoc/cljdoc-analyzer '{:git/tag "RELEASE"}' :as cljdoc && lein jar && lein pom && clojure -Tcljdoc analyze-local and ran successfully after the change.

FelipeCortez avatar Oct 10 '25 22:10 FelipeCortez

@FelipeCortez could you add a link to the upstream PR that is blocking this one?

ghaskins avatar Nov 17 '25 13:11 ghaskins

@FelipeCortez could you add a link to the upstream PR that is blocking this one?

The PR got merged last month. I was waiting for the new SDK version release so we're able to pick up the change, and it seems like it finally happened last Friday. Updating the project.clj to test this out.

FelipeCortez avatar Nov 17 '25 13:11 FelipeCortez

@ghaskins seems like tests are passing now, but I had to resolve a merge conflict and need a new review.

FelipeCortez avatar Nov 17 '25 13:11 FelipeCortez

@FelipeCortez it still seems to need a rebase

ghaskins avatar Nov 17 '25 19:11 ghaskins

@FelipeCortez it still seems to need a rebase

sorry about that! I'm used to keeping the merge commits. should be good now

FelipeCortez avatar Nov 17 '25 20:11 FelipeCortez