Create directory to group native samples
Create directory to group native samples
Fixes capa#1787 Depends on: mandiant/capa-testfiles#279
Since after changing the native samples path, pytest file paths have been updated accordingly
However, one expected failure test (xfailed) unexpectedly passed.
I ran pytest on the latest master branch, and it produced the same result.
Pytest Results After Updating File Paths
Pytest Results for latest master branch
Request for Feedback
Can I get feedback on resolving this issue?
Checklist
- [x] No CHANGELOG update needed
- [x] No new tests needed
- [x] No documentation update needed
@mr-tz
I changed the path of the test file in the test scripts to match the capa-testfiles PR: capa-testfiles PR #279
Here is the pytest result. However, tests/test_scripts.py::test_proto_conversion, which was expected to fail, was passed.
I also checked pytest against the latest master branch, and it shows the same result.
Can I get feedback on this?
I'll take another closer look and think about the naming. Maybe we add OS or arch but I'd like to keep it simple.
Hi @mr-tz, just checking in — any updates on the PR or anything you’d like me to adjust?
Hey, sorry it may take a bit on my end. Thanks for the ping.