capa icon indicating copy to clipboard operation
capa copied to clipboard

Create directory to group native samples

Open hcnpeiris opened this issue 11 months ago • 4 comments

Create directory to group native samples

Fixes capa#1787 Depends on: mandiant/capa-testfiles#279

Since after changing the native samples path, pytest file paths have been updated accordingly

However, one expected failure test (xfailed) unexpectedly passed.
I ran pytest on the latest master branch, and it produced the same result.

Pytest Results After Updating File Paths

Image 2025-03-11 at 18 21

Pytest Results for latest master branch

Image 2025-03-11 at 16 51

Request for Feedback

Can I get feedback on resolving this issue?

Checklist

  • [x] No CHANGELOG update needed
  • [x] No new tests needed
  • [x] No documentation update needed

hcnpeiris avatar Mar 11 '25 13:03 hcnpeiris

@mr-tz
I changed the path of the test file in the test scripts to match the capa-testfiles PR: capa-testfiles PR #279

Here is the pytest result. However, tests/test_scripts.py::test_proto_conversion, which was expected to fail, was passed.
I also checked pytest against the latest master branch, and it shows the same result.
Screenshot 2025-03-16 at 20 51 06 Can I get feedback on this?

hcnpeiris avatar Mar 17 '25 04:03 hcnpeiris

I'll take another closer look and think about the naming. Maybe we add OS or arch but I'd like to keep it simple.

mr-tz avatar Mar 20 '25 18:03 mr-tz

Hi @mr-tz, just checking in — any updates on the PR or anything you’d like me to adjust?

hcnpeiris avatar Mar 27 '25 04:03 hcnpeiris

Hey, sorry it may take a bit on my end. Thanks for the ping.

mr-tz avatar Mar 27 '25 08:03 mr-tz