capa icon indicating copy to clipboard operation
capa copied to clipboard

bump the linux standalone build to use python 3.13 #2594

Open dhruvak001 opened this issue 1 year ago • 13 comments

Fixes https://github.com/mandiant/capa/issues/2594

[x] No CHANGELOG update needed [x] No new tests needed [x] No documentation update needed

dhruvak001 avatar Feb 05 '25 19:02 dhruvak001

@dhruvak001, I already working on this issue. Please pick some other issue.

v1bh475u avatar Feb 05 '25 19:02 v1bh475u

@v1bh475u oh okay! you can check the changes if it may help.

dhruvak001 avatar Feb 05 '25 19:02 dhruvak001

@v1bh475u btw this https://github.com/mandiant/capa/pull/2595 now passes "build / PyInstaller for ubuntu-20.04 / Py 3.13 (pull_request)" Action.

@williballenthin is this all for this issue or it needs more updates (@v1bh475u)

dhruvak001 avatar Feb 05 '25 19:02 dhruvak001

please remove the changes to the IDA plugin and do not increase the minimum required Python version. this PR should be totally focused on only the standalone binary build.

williballenthin avatar Feb 05 '25 20:02 williballenthin

@williballenthin do this FAILED tests/test_main.py::test_main_dotnet needed to be rectified?

dhruvak001 avatar Feb 05 '25 21:02 dhruvak001

do they have anything to do with the changes you made? you should be able to confirm locally.

williballenthin avatar Feb 06 '25 06:02 williballenthin

@williballenthin locally testing this FAILED tests/test_main.py::test_main_dotnet passed for me. The error here is coming from .NET files which comes for testing from submodules tests/data https://github.com/mandiant/capa-testfiles/tree/6cf615dd014de8b1979d2619d7f832b4133bfa11

dhruvak001 avatar Feb 06 '25 23:02 dhruvak001

are you running on the latest master? make sure you've updated your branch please.

williballenthin avatar Feb 07 '25 06:02 williballenthin

@williballenthin the test failing here in Github actions seems to be some other issue! can please you check this Dotnet Test Failure

dhruvak001 avatar Feb 07 '25 21:02 dhruvak001

so you are not able to reproduce the problem locally?

williballenthin avatar Feb 08 '25 07:02 williballenthin

@williballenthin yeah, even with the latest master.

dhruvak001 avatar Feb 08 '25 11:02 dhruvak001

@williballenthin can you please review it?

dhruvak001 avatar Feb 11 '25 18:02 dhruvak001

@williballenthin I have resolved the comments.

dhruvak001 avatar Mar 14 '25 18:03 dhruvak001