mandiant
Add adjustable font size for HiDPI monitors for IDA plugin #2570
PR for https://github.com/mandiant/capa/issues/2570
Changes Added font settings and menu options in form.py.
Modified the font initialization in view.py to respect the default font size.
No changes needed in model.py.
These changes will allow users to adjust the font size in the capa plugin via the new menu options under the "Options" menu.
[x] No CHANGELOG update needed [x] No new tests needed [x] No documentation update needed
Hey @still34 and @williballenthin @mike-hunhoff a PR for issue#2570
Test Fail 1: Code Styles flake8 is failing due to import in form.py on line 1209, but taking it to top would make circular dependency. We can use Lazy Typing to avoid these, but it would be better if we just skip these test for this import(avoiding circular dependency).
Test Fail 2: Rule Linter is failing due to a error for which we have to change the submodule capa-rules for which i had a PR https://github.com/mandiant/capa-rules/pull/988 . BTW in my other PR https://github.com/mandiant/capa/pull/2581 these test was passed directly by @williballenthin .
@dhruvak001 would you please show some screenshots of the settings with different values?
from email with @dhruvak001:
Moreover, is there any way I can access IDA Pro. As I had solved an issue https://github.com/mandiant/capa/pull/2583 . It was some basic feature addition which I think could directly do it, but I had also tried the IDA free license to check the feature but the free version can't import the .py file(as it needs the .idc file in the free version). Can you please do something about it like to help in checking the feature or accessing IDA Pro?
We can test this out locally with our IDA licenses.
In the future, please only work on features you can test directly (and add test cases whenever possible!). If you need additional resources, like a software license, please raise this prior to assigning the issue or submitting a PR.
Stale PR plus new Qt5/Pyside6 in newest IDA requiring a new approach here most likely.
