capa icon indicating copy to clipboard operation
capa copied to clipboard

feat: auto-generate ruleset cache on source change

Open fariss opened this issue 1 year ago • 3 comments

Closes #1898. This is a proposal for the issue discussed in #1898.

Let's test out its feasibility and make sure it does not introduce an overhead.

fariss avatar Jun 07 '24 11:06 fariss

Do you think it's possible to cleanly move the dev/git logic into capa.main?

agree here to move this to capa.main or a utils file.

mr-tz avatar Jun 07 '24 17:06 mr-tz

beyond splitting this up we'd prefer to call this from capa.main (and not deep in the library) can we add the check if this is a dev environment there instead? (e.g. around get_rules)

Moving the dev environment checks to capa.main and importing them from capa.main would create circular dependencies when I tested it.

fariss avatar Jun 10 '24 11:06 fariss

beyond splitting this up we'd prefer to call this from capa.main (and not deep in the library) can we add the check if this is a dev environment there instead? (e.g. around get_rules)

Moving the dev environment checks to capa.main and importing them from capa.main would create circular dependencies when I tested it.

I mean to call it from there not to implement them in main.

mr-tz avatar Jun 10 '24 12:06 mr-tz

Any concerns or blockers before merging this?

mr-tz avatar Jul 22 '24 11:07 mr-tz

ping @s-ff, @williballenthin, @mike-hunhoff

mr-tz avatar Aug 06 '24 05:08 mr-tz