capa icon indicating copy to clipboard operation
capa copied to clipboard

make string length configurable and consistent across backends

Open linpeiyu164 opened this issue 2 years ago • 3 comments

closes #1303

Checklist

  • [x] No CHANGELOG update needed
  • [x] No new tests needed
  • [x] No documentation update needed

linpeiyu164 avatar Mar 31 '23 17:03 linpeiyu164

@linpeiyu164 do you expect to be able to resume work on this PR and/or shall we lend a hand to close it out?

williballenthin avatar May 10 '23 11:05 williballenthin

I have made the requested changes from the last review. I didn't notice the merge conflict but I just resolved it. There seems to be a failing check, but I think the PR will be done once I deal with it. Is there anything else I should change?

linpeiyu164 avatar May 10 '23 13:05 linpeiyu164

The mypy check was not triggered to run again so the results can't be seen here, but it ran successfully when I tested it locally: $ mypy --config-file .github/mypy/mypy.ini --check-untyped-defs capa/features/ Success: no issues found in 53 source files

linpeiyu164 avatar May 10 '23 15:05 linpeiyu164

closing due to inactivity and outdated code, will mark the issue as open again

mr-tz avatar Mar 22 '24 10:03 mr-tz