react-speed-book

react-speed-book copied to clipboard

just starting your book. stuck on this Windows_NT 10.0.16299 argv "Z:\\_dev\\node\\node.exe" "Z:\\_dev\\node\\node_modules\\npm\\bin\\npm-cli.js" "start" "development" node v6.10.2 npm v3.10.10 code ELIFECYCLE [email protected] start: `NODE_ENV=development webpack-dev-server --inline "development"` Exit status 1 Failed...

pmoon777

sagaban

img folder in root directory

2

First let me just say how much I have enjoyed reading this book. Seriously, thank you for sharing this wealth of knowledge publicly. You've done anyone working with React a...

zakfisher

NavLink renders li and grid-cell - not required

2

NavLink component did not get updated in last major refactor. It still renders `` as enclosing component. [Source](https://github.com/manavsehgal/react-speed-book/blob/c15-react-developer-experience/app/components/NavLink.jsx#L21) here. **Proposed solution.** Remove and just return Link or `` component. **How...

manavsehgal

Component Lifecycle Questions

1

Dear Manav, In component lifecycle chapter, it states: "componentWillMount is invoked once. It is invoked both on client and server. It is invoked immediately before the initial rendering." Can you...

diehell

NavLink propType for children is defined as text. [Source](https://github.com/manavsehgal/react-speed-book/blob/c15-react-developer-experience/app/components/NavLink.jsx#L8) here. **Solution.** Change to propType node so NavLink can handle images as children for example. **Reproduce.** Wrapping NavLink with image child...

manavsehgal