cycle icon indicating copy to clipboard operation
cycle copied to clipboard

Cycle plugin doesn't calculate Cycle height with jQuery UI 1.8.11

Open yannickoo opened this issue 12 years ago • 1 comments

Hey Mike,

I guess that jQuery Cycle is not compatible with jQuery UI 1.8.11 because there is a function which extends the outerWidth and the outerHeight function.

Checkout the jsFiddle and inspect the HTML, you will see that the #cycle has no height, only a position: relative. The #cycle element will get a height when you remove jQuery UI from the External ressources tab.

In line #165 you can see following function which overrides outerWidth and outerHeight:

$.fn[ "outer" + name] = function( size, margin ) {
  if ( typeof size !== "number" ) {
    return orig[ "outer" + name ].call( this, size );
  }

  return this.each(function() {
    $( this).css( type, reduce( this, size, true, margin ) + "px" );
  });
};

I hope we can fix that :) BTW thank you for such a great jQuery plugin :+1:

yannickoo avatar Feb 28 '13 17:02 yannickoo

Confirmed. This is a pretty significant issue for Drupal 7 sites running jQuery Update (a fairly common plugin) along with the latest version of Views Slideshow, because jQuery Update applies jQuery UI 1.8.11 when you opt to run jQuery 1.8. This applies to Cycle 3.0.2.

lpeabody avatar May 13 '13 15:05 lpeabody