developerguides icon indicating copy to clipboard operation
developerguides copied to clipboard

Keeper Bot Set-Up guide severely outdated - faucet on Goerli not set-up correctly either

Open henryksarat opened this issue 2 years ago • 0 comments

It currently references the Kovan testnet and I have been trying to get it to work against the Goerli testnet. The faucet on the Goerli testnet seems to not have been set-up correctly for MKR either because it gives 0 MKR, instead of 1 MKR like it should.

Here is the page to the guide I'm refering to: https://github.com/makerdao/developerguides/blob/master/keepers/auction-keeper-bot-setup-guide/auction-keeper-bot-setup-guide.md.

Note: for the address below I used https://chainlog.makerdao.com/

In particular, here is the issue with the faucet:

I ran the following SETH command to try to get MKR token:

seth send 0xa473CdDD6E4FAc72481dc36f39A409D86980D187 'gulp(address)' 0xc5E4eaB513A7CD12b2335e8a0D57273e13D499f7

Here is the transaction, notice that 0 MKR was sent https://goerli.etherscan.io/tx/0xc05bbbd34d1495f05f27e1834dca16e620b4f5c32f3fb6a014fbfc814467e811

As a check against myself, I tried to call the same faucet to get USDC and I was able to get 50000. Here is the command:

seth send 0xa473CdDD6E4FAc72481dc36f39A409D86980D187 'gulp(address)' 0x6fb5ef893d44f4f88026430d82d4ef269543cb23

Here is the transaction https://goerli.etherscan.io/tx/0x49c10dcd637823b90eeeb7e9785f80bbd9e54a48a704d6ea6a9b85c1e51aedf6

My theory: After looking at the smart contract for the faucet https://goerli.etherscan.io/address/0xa473CdDD6E4FAc72481dc36f39A409D86980D187#code, the amount has not been set by the owner. Here is the smart contract code for gulp:

    function gulp(address gem) external  {
        require(list[address(0)] == 1 || list[msg.sender] == 1, "token-faucet/no-whitelist");
        require(!done[msg.sender][gem], "token-faucet/already-used_faucet");
        require(ERC20Like(gem).balanceOf(address(this)) >= amt[gem], "token-faucet/not-enough-balance");
        done[msg.sender][gem] = true;
        ERC20Like(gem).transfer(msg.sender, amt[gem]);
    }

Any advice for me to proceed or if someone is able to update the docs?

henryksarat avatar Apr 07 '23 21:04 henryksarat