plane icon indicating copy to clipboard operation
plane copied to clipboard

Seprated env variables for specific app containers and added SSL feature using caddy

Open akshat5302 opened this issue 1 year ago • 1 comments

Changes: This PR includes seprated env variables for specific app containers and added SSL feature using caddy

Summary by CodeRabbit

  • New Features

    • Introduced a new Caddy configuration file for enhanced reverse proxy management.
    • Added a dynamic environment variable system for SSL certificate management.
    • Implemented a new build configuration for the proxy service utilizing Caddy.
    • Added a new service for live data handling with WebSocket support.
    • Enhanced installation script with improved error handling and version management.
  • Improvements

    • Streamlined Docker Compose configuration for better maintainability and clarity.
    • Enhanced routing capabilities within the Caddy server for multiple services.
    • Improved SSL configuration handling for secure deployments.
    • Increased reliability of the installation process through robust error checks.
  • Chores

    • Updated Dockerfile and associated scripts for initializing the Caddy web server.

akshat5302 avatar Aug 26 '24 13:08 akshat5302

Walkthrough

The GitHub Actions workflow was updated to detect changed files grouped by project areas and switched the proxy Docker build context from nginx to caddy. The application Dockerfile was modified to include the "live" scope in Turbo prune and build commands and copy related "live" files into the final image. The docker-compose.yml proxy service was enhanced with SSL environment variables, updated ports, volumes, dependencies, and an updated image tag.

Changes

Files Change Summary
.github/workflows/build-branch.yml Added step to detect changed files grouped by project areas; changed Docker build context and Dockerfile path from nginx to caddy.
aio/Dockerfile-app Included "live" scope in Turbo prune and build commands; copied "live" package and dist files into final image; added copying of node_modules.
deploy/selfhost/docker-compose.yml Expanded proxy environment variables for SSL and domain config; updated proxy image tag; exposed HTTP/HTTPS ports; added proxy volumes; extended proxy dependencies to include admin and live.

Sequence Diagram(s)

sequenceDiagram
    participant Workflow
    participant ChangedFilesAction
    participant DockerBuild
    participant DockerCompose

    Workflow->>ChangedFilesAction: Detect changed files by project area
    ChangedFilesAction-->>Workflow: Provide changed file groups
    Workflow->>DockerBuild: Build Docker image with updated context and scopes
    DockerBuild-->>Workflow: Build complete
    Workflow->>DockerCompose: Deploy with updated proxy config and volumes
    DockerCompose-->>Workflow: Services started with SSL and multi-port setup

🐇
A hop, a scope, a file to find,
Changes grouped, no path left behind.
From nginx paths to caddy’s door,
Live code joins the build once more.
With every step, the pipeline hums,
A rabbit’s cheer for what becomes! 🎉


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Aug 26 '24 13:08 coderabbitai[bot]

Pull Request Linked with Plane Work Items

Comment Automatically Generated by Plane

makeplane[bot] avatar Jun 20 '25 12:06 makeplane[bot]