devops icon indicating copy to clipboard operation
devops copied to clipboard
verified publisher icon mainflux

NOISSUE: Add Group-based Access Control to charts and update dependencies version

Open arvindh123 opened this issue 2 years ago • 3 comments

Pull request title should be MF-XXX - description or NOISSUE - description where XXX is ID of issue that this PR relate to. Please review the CONTRIBUTING.md file for detailed contributing guidelines.

What does this do?

This pull request (PR) introduces several changes to the Mainflux Helm chart, providing the following functionalities and improvements:

  • Enhanced Group-based Access Control: The PR updates the group-based access control for Mainflux components, specifically for users and things. This improvement strengthens the access control mechanism, allowing for more refined and granular permissions management within Mainflux.

  • Removal of Auth and Keto Components: The PR removes the auth and keto components from the Helm charts. This indicates a shift in the architecture or functionality of Mainflux, where these components are no longer necessary.

  • Dependency Version Updates: The PR updates the versions of dependencies used in the Helm charts.

  • Support for Latest Kubernetes Version: The PR modifies the Helm chart to support the latest version of Kubernetes. This enables Mainflux to be deployed using the updated Helm chart on the most recent Kubernetes release.

  • This PR specifically supports Mainflux version 0.14.0 and above. Therefore, it is recommended to use this updated Helm chart with Mainflux instances running version 0.14.0 or higher for optimal compatibility and functionality.

This PR branch is created from PR #125

Which issue(s) does this PR fix/relate to?

No

List any changes that modify/break current functionality

This pull request (PR) introduces changes to the Helm chart that impact its compatibility with Mainflux versions. Specifically, the modified Helm chart will only be compatible with Mainflux version 0.14.0 and above. Users attempting to run Mainflux versions lower than 0.14.0 with this updated Helm chart will encounter issues and will not be able to successfully deploy or use it.

Have you included tests for your changes?

Did you document any new/modified functionality?

Yes , updated Readme.md

Notes

arvindh123 avatar Jun 19 '23 06:06 arvindh123

Could you please create a contributing guide for this repo instead of pointing to another repo. Also my PR was closed in favour of this PR, so do you expect me to continue with this PR? The helm chart should work reliably with current (1.25+) Kubernetes, or do you disagree with this?

kibahop avatar Jun 21 '23 08:06 kibahop

There is probably no need for new guidelines, but we should update the README with a link to the existing one. I think no actions from you, @arvindh123 included your work in this PR. Right, @arvindh123?

dborovcanin avatar Jun 28 '23 11:06 dborovcanin

There is probably no need for new guidelines, but we should update the README with a link to the existing one. I think no actions from you, @arvindh123 included your work in this PR. Right, @arvindh123?

yes @dborovcanin, Included @kibahop changes in this PR And Ready for review

arvindh123 avatar Jun 30 '23 06:06 arvindh123