talon icon indicating copy to clipboard operation
talon copied to clipboard

Increase flexibility of bruteforce signature extration

Open RonRademaker opened this issue 7 years ago • 8 comments

Allows overriding line length, max line length (useful if you expect disclaimers) and greetings (useful from a language perspective) when extracting signatures bruteforce

RonRademaker avatar May 16 '18 09:05 RonRademaker

Can one of the admins verify this patch?

mailgun-ci avatar May 16 '18 09:05 mailgun-ci

@mailgun-ci test this please

obukhov-sergey avatar Aug 07 '18 07:08 obukhov-sergey

Thanks for the feedback, I processed it

RonRademaker avatar Aug 14 '18 08:08 RonRademaker

@mailgun-ci test this please

obukhov-sergey avatar Nov 02 '18 09:11 obukhov-sergey

@RonRademaker sorry for delay with the merge, can you plz add abc to setup.py to make tests pass?

obukhov-sergey avatar Nov 02 '18 11:11 obukhov-sergey

Any way I can locally run the tests to see if they pass before pushing changes?

RonRademaker avatar Nov 02 '18 11:11 RonRademaker

@mailgun-ci test this please

obukhov-sergey avatar Nov 05 '18 07:11 obukhov-sergey

@RonRademaker sure, just run nosetests from the repo folder, you might need to "pip install nose" and "pip install mock", they're also in test_require part of setup.py; we plan to migrate to travis ci as well, so that you don't have to run tests yourself locally.

obukhov-sergey avatar Nov 05 '18 07:11 obukhov-sergey