ChimpKit2 icon indicating copy to clipboard operation
ChimpKit2 copied to clipboard

Success and Failure selectors mixed up in CKDialogController performSignup

Open iwankerl opened this issue 15 years ago • 3 comments

The code assigns the wrong values to the properties:

list.onFailure = self.onSuccess; list.onSuccess = self.onFailure;

iwankerl avatar May 05 '10 13:05 iwankerl

As it turns out, this appears to be due to a mixup of these selectors somewhere deeper down. A list signup failure is getting sent to my success method.

iwankerl avatar May 05 '10 13:05 iwankerl

Now it looks like my previous comment is due to a misunderstanding. I sent in a bad email address and my success method was called, but the data contained code = 502; error = "Invalid Email Address: huj";

I thought that would have been sent to my failure method but that might just be there for network connection failures.

iwankerl avatar May 05 '10 13:05 iwankerl

This reason for this is that the MailChimp API originally did not return JSON on this endpoint only 'true' or 'false'. I brought this to the attention of their engineers, so maybe they fixed it. I'll take a look and update the code if it is returning a proper format now.

twoism avatar May 05 '10 17:05 twoism