Sharp fit

Open seb-celinedesign opened this issue 5 years ago • 4 comments

Add the new Sharp fit parameter as a configuration option. Replace the deprecated max parameter.

Jun 06 '20 18:06 seb-celinedesign

Hi @CelineDesign, could you add a test?

Jun 07 '20 09:06 StarpTech

Hi, just add the fit option in the config object and a test for it. Is that what you wanted ?

Jun 07 '20 10:06 seb-celinedesign

I mean a test that guarantees the correct output.

Jun 07 '20 11:06 StarpTech

I mean a test that guarantees the correct output.

By "correct output" do you mean the file at the right dimension ? Because none of the current test is testing the generated image file and his properties. I think the role of gulp-responsive is to pass correct params to the Sharp library, which is the one who manipulate image files.

Jun 08 '20 07:06 seb-celinedesign