magicui icon indicating copy to clipboard operation
magicui copied to clipboard

[Developer Experience] We need to enforce linting / formatting standards

Open dillionverma opened this issue 1 year ago • 1 comments

Can someone make a PR to enforce prettier + eslint standards so that all new PRs have the same format?

We might need some sort of lint on commit or lint on deploy flow.

Need some input from the community on best developer experience

https://github.com/shadcn-ui/ui is a good standard to refer to imo

dillionverma avatar May 26 '24 05:05 dillionverma

Contentlayer config change detected. Updating type definitions and data...
Warning: Found 17 problems in 43 documents.

 └── 17 documents contain field data which didn't match the structure defined in the document type definition. (Skipping documents)

     • "docs/changelog.mdx" of type "Doc" has the following incompatible fields:
       • published: "false\r"

We also need a better pre-commit hook since our contributors use different operating systems. We need to establish a standard rule to ensure consistency across all OS systems.

This error can be temporarily resolved by changing your Git configuration with the command git config --global core.autocrlf input. Linux and Mac have a different end-of-line system than Windows, so converting to CRLF is causing the error. Setting autocrlf to input will use the end-of-line format as it is in the GitHub repo, which should solve the issue.

However, I recommend re-cloning the entire repo from scratch after changing the settings. Additionally, restart your terminal, code editor, and ideally, your PC or laptop.

itsarghyadas avatar May 26 '24 14:05 itsarghyadas

merged!

closing for now

dillionverma avatar Jul 01 '24 22:07 dillionverma