magicui icon indicating copy to clipboard operation
magicui copied to clipboard

feat: add a new highlighter component

Open Pratiyankkumar opened this issue 11 months ago • 8 comments

Added a new Highlighter component which highlights the text as it were highlighted by a human . Additional features include:

  1. Colour of highlighting : We can provide the colour of highlighting as a prop.
  2. Action of highlighter: We can provide the action of highlighter as a prop , which can be a circle or highlighter.

Preview shown in the image : Screenshot 2025-02-11 203134

Pratiyankkumar avatar Feb 11 '25 15:02 Pratiyankkumar

@Pratiyankkumar is attempting to deploy a commit to the product-studio Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Feb 11 '25 15:02 vercel[bot]

@dillionverma Please take a look at this.

Pratiyankkumar avatar Feb 11 '25 15:02 Pratiyankkumar

@dillionverma Appreciate you taking a look! 👀 Let me know if it's good to merge.

Pratiyankkumar avatar Feb 12 '25 03:02 Pratiyankkumar

Great component idea, I could see it being useful for a lot of cases.

However, I think the PR in it's current state feels incomplete.

Some points to improve:

  1. Expose access to all underlying props https://github.com/rough-stuff/rough-notation. Looks like there are more annotation types but this PR limits it to only 2. There are also several other useful props which are hidden.
  2. Give more demo examples

dillionverma avatar Feb 17 '25 07:02 dillionverma

ok will do that, thanks for pointing out

Pratiyankkumar avatar Feb 17 '25 07:02 Pratiyankkumar

Great component idea, I could see it being useful for a lot of cases.

However, I think the PR in it's current state feels incomplete.

Some points to improve:

  1. Expose access to all underlying props https://github.com/rough-stuff/rough-notation. Looks like there are more annotation types but this PR limits it to only 2. There are also several other useful props which are hidden.
  2. Give more demo examples

@dillionverma Added more annotations ✅ Added other useful props to give full access of the component to the user ✅ Given more demo examples ✅ here are the changes :

https://github.com/user-attachments/assets/fd3c8cf5-f146-4793-a236-e77d3bd05529

Pratiyankkumar avatar Feb 20 '25 09:02 Pratiyankkumar

@dillionverma Please tell me if its good to merge or something else is remaining

Pratiyankkumar avatar Feb 21 '25 02:02 Pratiyankkumar

We apologize for the delay. We will review it as soon as we have time and get back to you. Thank you.

itsarghyadas avatar Mar 28 '25 11:03 itsarghyadas