magicui icon indicating copy to clipboard operation
magicui copied to clipboard

#129 buttons

Open diip3sh opened this issue 1 year ago • 1 comments

#129 - Custom Buttons added

diip3sh avatar Jul 11 '24 06:07 diip3sh

Someone is attempting to deploy a commit to the product-studio Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Jul 11 '24 06:07 vercel[bot]

@pilladipesh33 Great work on this PR! However, having all this in one file might make it difficult for users to copy-paste quickly. I think a better approach would be to create a button page where each button is displayed individually, allowing users to easily copy-paste their preferred code.

For now, I’ll be closing this PR, but if you’re interested in creating another PR with the requested changes, that would be awesome. Thank you for your contribution!

itsarghyadas avatar Dec 13 '24 07:12 itsarghyadas

@itsarghyadas that's what I asked and it was suggested to add all button in same page

I would love to create another PR, just list out all the requirements and I will work on it

diip3sh avatar Dec 13 '24 07:12 diip3sh

You’re absolutely right - it would be very useful to showcase all the buttons on a single page, but not within a single component. Instead, I suggest having individual preview containers for each button, like in the example below:

image

What I’m thinking is that you create individual components for each button with their respective names. Then, in a single .mdx file, you can display these buttons using <ComponentPreview name="button-1" /> or similar for each button as a variant.

itsarghyadas avatar Dec 13 '24 08:12 itsarghyadas