mage icon indicating copy to clipboard operation
mage copied to clipboard

[DMC] Dihada Implementation

Open DreamWaker opened this issue 3 years ago • 5 comments

Adds the Dihada card Most of the code was based on earlier working cards -3 Genesis Wave -11 Mob Rule

DreamWaker avatar Sep 13 '22 19:09 DreamWaker

You are trying to merge into magefree:FixBanishingLight as opposed to magefree:master.

PurpleCrowbar avatar Sep 13 '22 20:09 PurpleCrowbar

This is also failing to compile. Try to fix these build errors: https://app.travis-ci.com/github/magefree/mage/builds/255524307

[INFO] -------------------------------------------------------------
[ERROR] COMPILATION ERROR : 
[INFO] -------------------------------------------------------------
[ERROR] /home/travis/build/magefree/mage/Mage.Sets/src/mage/cards/d/DihadaBinderOfWills.java:[158,9] illegal start of expression
[ERROR] /home/travis/build/magefree/mage/Mage.Sets/src/mage/cards/d/DihadaBinderOfWills.java:[162,9] illegal start of type
[ERROR] /home/travis/build/magefree/mage/Mage.Sets/src/mage/cards/d/DihadaBinderOfWills.java:[162,34] ';' expected
[ERROR] /home/travis/build/magefree/mage/Mage.Sets/src/mage/cards/d/DihadaBinderOfWills.java:[162,48] <identifier> expected
[ERROR] /home/travis/build/magefree/mage/Mage.Sets/src/mage/cards/d/DihadaBinderOfWills.java:[168,9] illegal start of type
[ERROR] /home/travis/build/magefree/mage/Mage.Sets/src/mage/cards/d/DihadaBinderOfWills.java:[168,34] ';' expected
[ERROR] /home/travis/build/magefree/mage/Mage.Sets/src/mage/cards/d/DihadaBinderOfWills.java:[168,48] <identifier> expected
[ERROR] /home/travis/build/magefree/mage/Mage.Sets/src/mage/cards/d/DihadaBinderOfWills.java:[172,9] illegal start of type
[ERROR] /home/travis/build/magefree/mage/Mage.Sets/src/mage/cards/d/DihadaBinderOfWills.java:[172,34] ';' expected
[ERROR] /home/travis/build/magefree/mage/Mage.Sets/src/mage/cards/d/DihadaBinderOfWills.java:[172,48] <identifier> expected
[ERROR] /home/travis/build/magefree/mage/Mage.Sets/src/mage/cards/d/DihadaBinderOfWills.java:[178,9] illegal start of type
[ERROR] /home/travis/build/magefree/mage/Mage.Sets/src/mage/cards/d/DihadaBinderOfWills.java:[178,23] <identifier> expected
[ERROR] /home/travis/build/magefree/mage/Mage.Sets/src/mage/cards/d/DihadaBinderOfWills.java:[180,1] class, interface, or enum expected
[INFO] 13 errors 

weirddan455 avatar Sep 13 '22 21:09 weirddan455

This is also failing to compile. Try to fix these build errors: https://app.travis-ci.com/github/magefree/mage/builds/255524307


[INFO] -------------------------------------------------------------

[ERROR] COMPILATION ERROR : 

[INFO] -------------------------------------------------------------

[ERROR] /home/travis/build/magefree/mage/Mage.Sets/src/mage/cards/d/DihadaBinderOfWills.java:[158,9] illegal start of expression

[ERROR] /home/travis/build/magefree/mage/Mage.Sets/src/mage/cards/d/DihadaBinderOfWills.java:[162,9] illegal start of type

[ERROR] /home/travis/build/magefree/mage/Mage.Sets/src/mage/cards/d/DihadaBinderOfWills.java:[162,34] ';' expected

[ERROR] /home/travis/build/magefree/mage/Mage.Sets/src/mage/cards/d/DihadaBinderOfWills.java:[162,48] <identifier> expected

[ERROR] /home/travis/build/magefree/mage/Mage.Sets/src/mage/cards/d/DihadaBinderOfWills.java:[168,9] illegal start of type

[ERROR] /home/travis/build/magefree/mage/Mage.Sets/src/mage/cards/d/DihadaBinderOfWills.java:[168,34] ';' expected

[ERROR] /home/travis/build/magefree/mage/Mage.Sets/src/mage/cards/d/DihadaBinderOfWills.java:[168,48] <identifier> expected

[ERROR] /home/travis/build/magefree/mage/Mage.Sets/src/mage/cards/d/DihadaBinderOfWills.java:[172,9] illegal start of type

[ERROR] /home/travis/build/magefree/mage/Mage.Sets/src/mage/cards/d/DihadaBinderOfWills.java:[172,34] ';' expected

[ERROR] /home/travis/build/magefree/mage/Mage.Sets/src/mage/cards/d/DihadaBinderOfWills.java:[172,48] <identifier> expected

[ERROR] /home/travis/build/magefree/mage/Mage.Sets/src/mage/cards/d/DihadaBinderOfWills.java:[178,9] illegal start of type

[ERROR] /home/travis/build/magefree/mage/Mage.Sets/src/mage/cards/d/DihadaBinderOfWills.java:[178,23] <identifier> expected

[ERROR] /home/travis/build/magefree/mage/Mage.Sets/src/mage/cards/d/DihadaBinderOfWills.java:[180,1] class, interface, or enum expected

[INFO] 13 errors 

@DreamWaker you should see about setting up the tests to run them locally so you know it works before pushing

Alex-Vasile avatar Sep 13 '22 22:09 Alex-Vasile

Ugh, feel stupid, forgot to add the list include... That should fix the errors at least...

DreamWaker avatar Sep 13 '22 23:09 DreamWaker

Ugh, feel stupid, forgot to add the list include... That should fix the errors at least...

It's still failing to build. Looks like you're still missing some includes. I recommend using an IDE like IntelliJ IDEA. The community edition is free and it will highlight lines that have errors for you and also put in the includes for you. If you hover over the red text, there should be an option to add missing include.

weirddan455 avatar Sep 13 '22 23:09 weirddan455

@DreamWaker , is it okay if I finish this card up and co-credit both of us?

awjackson avatar Sep 28 '22 08:09 awjackson

Sure.

DreamWaker avatar Sep 28 '22 11:09 DreamWaker