maevelander
Clean up the uninstall.php file
Cleaning up the uninstall.php for large parts.
- One note is that I've omitted the code that deletes images. I'm not sure if that should be deleted as it is a very good possibility that the images are also used on other places.
- Also omitted the removal of child posts, as I don't think this is possible within the plugin.
I've actually not tested this as I'm not developing on a site where I'd be fine with deleting the data I've got. I'd love to get your help with this 😃
This looks good but I need to make time to test this. Will do so over the weekend.
@JeroenSormani per Faisal's tests/note there can you double check the wipe all data function before we merge this to master? Cheers.
Fixed the issue, calling a function that the plugin introduces is of course not possible...
Great thanks. @Base29 please can you retest and confirm so we can merge this and release next version soon.
@JeroenSormani ,,, just checked this ... but still not working ... can you explain what did you changed in the code after my last comment ??
@JeroenSormani ... hope you are fine ... I have tried the code and the uninstall is still not working can you please check this ... also can you please let me know what changes have done with the code for uninstall after my comment from June 16 ... Thanks
Thanks Guys. Things have been busy so this has taken a back seat. But Jeroen has put so much work in to some great features and improvements. I'd really like to get this last thing working nicely so we can release the update.
@Base29 @EnigmaWeb sorry for the big delay, I've been quite distracted.
The exact changes I've done in between is a bit hard to check / keep track of. Basically I've done a full refactor of the uninstall.php file to make things cleaner and easier.
I've just taken a look at the code and found why it wasn't working. I've just pushed the fix for that.