EditorConfigLanguage icon indicating copy to clipboard operation
EditorConfigLanguage copied to clipboard

Crash when opening specific .editorconfig file

Open alexsorokoletov opened this issue 8 years ago • 3 comments

Installed product versions

  • Visual Studio: 2017 Community latest update (15.2/26430.14)
  • This extension: [1.17.207]

Description

Extension crashes as soon as I open .editorconfig from roslyn repo: https://github.com/dotnet/roslyn/blob/1be9034dcf0392fb0c15d5ffac7a4f35d4bcd51b/.editorconfig (now it's latest master)

Error from ActivityLog.xml

System.NullReferenceException: Object reference not set to an instance of an object.
   at EditorConfig.BraceMatchingTaggerProvider.CreateTagger[T](ITextView textView, ITextBuffer buffer) in C:\projects\editorconfiglanguage\src\BraceCompletion\BraceMatchingTaggerProvider.cs:line 16
   at Microsoft.VisualStudio.Text.Tagging.Implementation.TagAggregator`1.GatherTaggers(ITextBuffer textBuffer)

Steps to recreate

  1. Add .editor config as in here: https://github.com/dotnet/roslyn/blob/1be9034dcf0392fb0c15d5ffac7a4f35d4bcd51b/.editorconfig
  2. Open VS 2017 Community
  3. Open .editorconfig
  4. Get a dialog about exception crashed

Current behavior

Exception is crashing

Expected behavior

Should not crash

alexsorokoletov avatar Jun 27 '17 03:06 alexsorokoletov

I could not replicate this on Visual Studio Enterprise 15.3.5 on plugin version 1.173.216. Have you updated your community edition to the latest version and tried it again?

I could be wrong, but I think some features are only available in 15.3+ when it comes to .editorconfig files.

binaryn3xus avatar Oct 03 '17 14:10 binaryn3xus

@JoshuaGarrison27 let's then close and if I get that crashing again, I will ping you back. Current installation is updated already, I do not experience that problem but I also have different config now.

Thanks for looking!

alexsorokoletov avatar Oct 03 '17 18:10 alexsorokoletov

Sorry I couldn't reproduce it. Please feel free to submit another issue if you experience again.

@madskristensen Would you kindly close this issue if you are comfortable with the response

binaryn3xus avatar Oct 03 '17 19:10 binaryn3xus