PinePods icon indicating copy to clipboard operation
PinePods copied to clipboard

Limit of 100 episodes per RSS feed

Open feliscat opened this issue 9 months ago • 2 comments

I see that there's a hardcoded limit of 100 episodes found when an RSS feed is generated for a podcast. Could this be configurable by an environment variable? I assume it's there for performance issues, but I need to be able to have feeds with ~700 or ~800 episodes in them in my client.

Thanks for the great project, it's been a pleasure to use so far.

feliscat avatar May 02 '25 01:05 feliscat

I have a branch with this feature implemented on the backend. @madeofpendletonwool let me know if you want me to open a PR

bbirney avatar May 02 '25 18:05 bbirney

@bbirney Yeah! If you've got a branch that'd be great. It's yet another thing that was on the list of short term improvements.

madeofpendletonwool avatar May 03 '25 13:05 madeofpendletonwool

@bbirney did this ever get submitted? It's the thing holding me back from using this project.

feliscat avatar Jun 24 '25 00:06 feliscat

Yep, the PR is here: https://github.com/madeofpendletonwool/PinePods/pull/507 . I run my fork instead of this repo, so the folks using my pinepods instance have been relying on the change for a bit.

@madeofpendletonwool just had a child, so I think this project will probably move pretty slowly shortterm

bbirney avatar Jun 24 '25 00:06 bbirney

Oops, I swear I looked and didn't see that PR somehow. Thanks, I'll give your fork a spin.

feliscat avatar Jun 24 '25 00:06 feliscat

Yeah sorry @feliscat, trying to loop back around into Pinepods work again. Slowly starting all my work back up again here.

madeofpendletonwool avatar Jun 24 '25 00:06 madeofpendletonwool

I'll try and make a quick release in the next day that fixes this and imports, which I know is also broken and a simple fix.

madeofpendletonwool avatar Jun 24 '25 00:06 madeofpendletonwool

@madeofpendletonwool Don't apologize! I'm quite comfortable building the PR for now. Thanks for the work you do on this.

feliscat avatar Jun 24 '25 00:06 feliscat

I just created a release candidate for 0.7.9 that includes fixes for this and a bunch of other issues: https://github.com/madeofpendletonwool/PinePods/releases/tag/0.7.9rc1

Please give it a go and let me know if you hit any snags.

madeofpendletonwool avatar Jun 28 '25 14:06 madeofpendletonwool

@madeofpendletonwool Pulled and tried it, but I'm getting some db errors:


db          | 2025-07-07 15:11:12.323 UTC [47] ERROR:  column "playbackspeed" does not exist at character 8
db          | 2025-07-07 15:11:12.323 UTC [47] STATEMENT:  SELECT PlaybackSpeed FROM "Users" WHERE UserID = $1
db          | 2025-07-07 15:11:12.702 UTC [50] ERROR:  relation "RssKeys" does not exist at character 20
db          | 2025-07-07 15:11:12.702 UTC [50] STATEMENT:  SELECT RssKey FROM "RssKeys" WHERE UserID = $1

Maybe I missed a migration somewhere?

feliscat avatar Jul 07 '25 15:07 feliscat

I think you might be 1 version off the latest nightly. I was testing the upgrade process yesterday and discovered this. I needed to build a migration for that playground stuff specifically as I believe I pushed that after fixing.

madeofpendletonwool avatar Jul 07 '25 20:07 madeofpendletonwool

Oh actually did you pull 0.7.9rc1 specifically? That would explain it. Pull nightly. That will fix it.

madeofpendletonwool avatar Jul 07 '25 20:07 madeofpendletonwool

@madeofpendletonwool That's the problem - I was running that tag. nightly worked. Thank you for all the stuff you do!

feliscat avatar Jul 08 '25 17:07 feliscat

I just tried the Nightly version as well, and my RSS feed is invalid because some <'s are replaced with &lt;, and >'s with &gt;. I doubt this is related to this story, but I thought I'd mention it. I attached an rss feed of the Pinepods - Pinepods News Feed podcast here, so you can see what is happening for me.

pinepods-rss.txt

ruudschouten avatar Jul 09 '25 16:07 ruudschouten

Hey @ruudschouten, thanks for letting me know. I have 0.7.9 ready to go as of today and will adjust this quickly before the release.

madeofpendletonwool avatar Jul 09 '25 22:07 madeofpendletonwool

This has been resolved with the release of 0.7.9. There's no longer a limit. I think from a performance perspective it should be fine. That rss feed generation process is extremely quick. Let me know if any performance problems are noticed. Also the issue that @ruudschouten pointed out was fixed as well

madeofpendletonwool avatar Jul 11 '25 00:07 madeofpendletonwool