macvim icon indicating copy to clipboard operation
macvim copied to clipboard

tests: Remove MacVim-specific flaky tests guard

Open ychin opened this issue 3 months ago • 0 comments

A while ago, flaky Vim tests would routinely fail in MacVim's repo and an intermediate hack was added to essentially pass all flaky tests and these failed tests would be added to a "pending" list for review. The issue is that this essentially gives a free pass for tests to fail and no one really has time to look at these "pending" tests when they see a green checkmark. It's much better to fail early and fast so we are forced to address them as they come up. Waiting till later tends to make these test failures harder to isolate and diagnose, leading to us just ignoring them. Even worse, flaky tests are retried multiple times, so they end up making MacVim CI run longer.

Simply revert the changes that added these flaky tests and we should fix broken tests as they come up just like any other non-flaky tests.

ychin avatar Oct 31 '25 00:10 ychin