macvim icon indicating copy to clipboard operation
macvim copied to clipboard

glyphs rendering issue

Open cridemichel opened this issue 5 years ago • 4 comments

Describe the bug If I disable the option 'Use Core Text Renderer" and I set a font size larger than h18 (e.g. h19), I get vertical bars after right separators (e.g. look on the right of the following image after "5%") Schermata 2020-05-30 alle 10 42 33 This is with Hack Nerd Font but note that I obtain this behavior with all fonts I have installed, i.e. FiraCode, Meslo, Hack Nerd Font Mono, JetBeans, JetBeans Mono, etc.

To Reproduce Detailed steps to reproduce the behavior:

  1. Install the "lightline" plugin (see https://github.com/itchyny/lightline.vim)
  2. Install the "Hack Nerd Font" (see https://github.com/ryanoasis/nerd-fonts)
  3. Add following settings to your .vimrc:
let g:lightline = {
      \ 'separator': { 'left': '_LS_', 'right': '_RS_' },
      \ 'colorscheme': 'deus',
      \ 'active': {
      \   'left': [ [ 'mode', 'paste' ],
      \             [ 'relativepath', 'extraflags', 'gitstat'] ],
      \   'right': [ [ 'lineinfo' ],
      \              [ 'percent' ],
      \              [ 'fileformat', 'fileencoding', 'filetype' ], 
      \              [ 'linter_checking', 'linter_errors', 'linter_warnings', 'linter_ok' ] 
      \            ]
      \ },
      \ }  

where LS and RS are left and right triangular separators as shown in the above image which I uploaded

Environment (please complete the following information):

  • Vim version:
VIM - Vi IMproved 8.2 (2019 Dec 12, compiled Apr 12 2020 00:47:07)
macOS version
Included patches: 1-539
Compiled by [email protected]
Huge version with MacVim GUI.  Features included (+) or not (-):
+acl               +comments          +find_in_path      +lispindent        +multi_byte        +reltime           +terminal          +wildignore
+arabic            +conceal           +float             +listcmds          +multi_lang        +rightleft         +terminfo          +wildmenu
+autocmd           +cryptv            +folding           +localmap          -mzscheme          +ruby/dyn          +termresponse      +windows
+autochdir         +cscope            -footer            +lua/dyn           +netbeans_intg     +scrollbind        +textobjects       +writebackup
-autoservername    +cursorbind        +fork()            +menu              +num64             +signs             +textprop          -X11
+balloon_eval      +cursorshape       +fullscreen        +mksession         +odbeditor         +smartindent       +timers            -xfontset
+balloon_eval_term +dialog_con_gui    -gettext           +modify_fname      +packages          -sound             +title             +xim
+browse            +diff              -hangul_input      +mouse             +path_extra        +spell             +toolbar           -xpm
++builtin_terms    +digraphs          +iconv             +mouseshape        +perl/dyn          +startuptime       +transparency      -xsmp
+byte_offset       +dnd               +insert_expand     +mouse_dec         +persistent_undo   +statusline        +user_commands     -xterm_clipboard
+channel           -ebcdic            +job               -mouse_gpm         +popupwin          -sun_workshop      +vartabs           -xterm_save
+cindent           +emacs_tags        +jumplist          -mouse_jsbterm     +postscript        +syntax            +vertsplit
+clientserver      +eval              +keymap            +mouse_netterm     +printer           +tag_binary        +virtualedit
+clipboard         +ex_extra          +lambda            +mouse_sgr         +profile           -tag_old_static    +visual
+cmdline_compl     +extra_search      +langmap           -mouse_sysmouse    +python/dyn        -tag_any_white     +visualextra
+cmdline_hist      -farsi             +libcall           +mouse_urxvt       +python3/dyn       -tcl               +viminfo
+cmdline_info      +file_in_path      +linebreak         +mouse_xterm       +quickfix          +termguicolors     +vreplace
   system vimrc file: "$VIM/vimrc"
     user vimrc file: "$HOME/.vimrc"
 2nd user vimrc file: "~/.vim/vimrc"
      user exrc file: "$HOME/.exrc"
  system gvimrc file: "$VIM/gvimrc"
    user gvimrc file: "$HOME/.gvimrc"
2nd user gvimrc file: "~/.vim/gvimrc"
       defaults file: "$VIMRUNTIME/defaults.vim"
    system menu file: "$VIMRUNTIME/menu.vim"
  fall-back for $VIM: "/Applications/MacVim.app/Contents/Resources/vim"
Compilation: clang -c -I. -Iproto -DHAVE_CONFIG_H -DFEAT_GUI_MACVIM -Wall -Wno-unknown-pragmas -pipe  -DMACOS_X -DMACOS_X_DARWIN  -g -O2 -U_FORTIFY_SOURCE -D_FORTIFY_
SOURCE=1
Linking: clang   -L. -fstack-protector-strong -L/usr/local/lib -L/usr/local/opt/libyaml/lib -L/usr/local/opt/[email protected]/lib -L/usr/local/opt/readline/lib -L. -fstack
-protector-strong -L/usr/local/lib -L/usr/local/opt/libyaml/lib -L/usr/local/opt/[email protected]/lib -L/usr/local/opt/readline/lib  -L/usr/local/lib -o Vim -framework Coc
oa -framework Carbon       -lm  -lncurses -liconv -framework AppKit   -fstack-protector  -L/System/Library/Perl/5.18/darwin-thread-multi-2level/CORE
  • OS: Mac OSX Catalina 10.15.5
  • Terminal: GUI

cridemichel avatar May 30 '20 09:05 cridemichel

Sorry for the late response, but Core Text renderer should always be on and the option is mostly there for backwards compatibility reasons. I would probably remove / deprecate option soon. Why did you disable that option?

ychin avatar Aug 11 '20 10:08 ychin

Dear Yee Cheng, I disabled the core text rendered since it is slower and from time to time I get garbled text using it when scrolling,

best Cristiano

Cristiano De Michele [email protected]

Il giorno 11 ago 2020, alle ore 12:03, Yee Cheng Chin [email protected] ha scritto:

Sorry for the late response, but Core Text renderer should always be on and the option is mostly there for backwards compatibility reasons. I would probably remove / deprecate option soon. Why did you disable that option?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/macvim-dev/macvim/issues/1049#issuecomment-671853560, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADU4YGU3MH3WMDWTQOKOZATSAEJNJANCNFSM4NOTREWA.

cridemichel avatar Aug 11 '20 17:08 cridemichel

Ok. @cridemichel I think at this point you should probably consider non-Core Text path deprecated, and my current plan is to start deprecating it and merging the stateful renderer (which improves scrolling performance) by next release. As such, we probably won't actively fix bugs in the old renderer.

ychin avatar Aug 26 '20 02:08 ychin

ok best C.

Cristiano De Michele [email protected]

Il giorno 26 ago 2020, alle ore 04:54, Yee Cheng Chin [email protected] ha scritto:

Ok. @cridemichel https://github.com/cridemichel I think at this point you should probably consider non-Core Text path deprecated, and my current plan is to start deprecating it and merging the stateful renderer by next release.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/macvim-dev/macvim/issues/1049#issuecomment-680451561, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADU4YGR2AK3GFT267CROF5LSCR2OLANCNFSM4NOTREWA.

cridemichel avatar Aug 27 '20 08:08 cridemichel