Audiobooks.bundle icon indicating copy to clipboard operation
Audiobooks.bundle copied to clipboard

MetadataSearchResult modified to be more descriptive

Open twojciac opened this issue 4 years ago • 7 comments

Updated MetadataSearchResult to show the book title, author, and publishing year rather than just the title. This should improve the end user's ability to find the correct match rather than providing just the title which may have multiple results by various authors.

twojciac avatar May 12 '21 05:05 twojciac

This would be super helpful!

djdembeck avatar Aug 24 '21 14:08 djdembeck

Agreed - at the moment you have to cycle through the choices. Narrator would be helpful as well.

jt196 avatar Sep 21 '21 10:09 jt196

@twojciac just having a little play around with this code. The problem with how you've written it (or how the Audiobook metadata agent works) is that when you save the metadata, the descriptive title is saved instead of the book title. So you end up with the description string description = '\"%s\" by %s [%s]' % (r['title'], r['artist'], r['year']) instead of just r['title'] in the name of the book.

*EDIT: I think this may have been as I hadn't removed the original results.Append(MetadataSearchResult(... line, just testing it and it seems to work.

jt196 avatar Sep 21 '21 14:09 jt196

Don't have time to faff around with pulling etc, but if you want to get the narrator to display you should replace the line:

info.append({'id': itemId, 'title': title, 'year': year, 'date': date, 'score': score, 'thumb': thumb, 'artist' : author}) with info.append({'id': itemId, 'title': title, 'year': year, 'date': date, 'score': score, 'thumb': thumb, 'artist' : author, 'narrator': narrator})

and the line: description = '\"%s\" by %s [%s]' % (r['title'], r['artist'], r['year']) with description = '\"%s\" by %s [%s] narr: %s' % (r['title'], r['artist'], r['year'], r['narrator'])

jt196 avatar Sep 21 '21 14:09 jt196

This feature has already been implemented in the re-written fork: https://github.com/seanap/Audiobooks.bundle

djdembeck avatar Sep 21 '21 15:09 djdembeck

Apologies, wasn't aware there was an active fork. Will chuck in a feature request then.

jt196 avatar Sep 21 '21 15:09 jt196

@djdembeck added a new feature request and the appropriate code for the rewrite.

jt196 avatar Sep 21 '21 15:09 jt196