git-credential-github-apps icon indicating copy to clipboard operation
git-credential-github-apps copied to clipboard
verified publisher icon mackee

Support wwwauth[] which added in Git 2.41.0

Open tchssk opened this issue 2 years ago • 3 comments

Hi.

Since Git 2.41, git-credential-github-apps doesn't work properly. This is because wwwauth[] was added to the credential helper protocol.

This pull request adds support for wwwauth[]. It's working correctly in my environment.

Thank you for the great software.

  • https://github.blog/2023-06-01-highlights-from-git-2-41/
  • https://github.com/git/git/compare/af5388d2ddb0bc7c22fbe698078f4ca07879d954...5f2117b24f568ecc789c677748d70ccd538b16ba
  • https://git-scm.com/docs/git-credential#Documentation/git-credential.txt-codewwwauthcode

tchssk avatar Jun 25 '23 09:06 tchssk

Hey @tchssk , I went ahead and forked this repo and merged your PR at Avinode/git-credential-github-apps. We started using this Git credentials provider and needed this and other security related patches applied in order to continue utilizing it. We have also published a v1.2.0 release there.

I don't want to step on anyone's toes, and will gladly close down the fork if this repo comes back to life.

Thanks for this fix! We needed it!

pedrohdz avatar Sep 14 '23 14:09 pedrohdz

That's excellent🙂 I'll take a look at it later. Thank you for notifying me. @pedrohdz

tchssk avatar Sep 16 '23 15:09 tchssk

@mackee

I've been using this for several months and it's working good. Would you please review and merge this pull request (and opened others) ? I appreciate your help.

tchssk avatar Nov 07 '23 06:11 tchssk