Maciej Falkiewicz

Results 20 comments of Maciej Falkiewicz

hey, what is the status of this one? :)

@francois-rozet please have a look at this one :) I added all the functionalities expected in this PR, however, I can imagine you would see some parts implemented/organized differently so...

1. > Is it expected that the formula written in the docstrings does not correspond to Eq. (12) in your paper? It depends on your preference :) What I put...

> I just pused a commit that moves inference components into different files, which should make it easier to read/add/maintain code. I think you can move your two losses into...

@francois-rozet I applied all the modifications that you suggested. 1. I tired building the documentation locally to check if it renders correctly, but I get the following error message ```bash...

> Did you install the docs dependencies? I thought so but that was not the case. Now works fine. > By the way, for the tests, I think it will...

> P.S. I will review next week. Long week it has been :) Do you want me to prepare the notebook(s) before your review?

@JoanaMarieL is there any hope? There is plenty of gradient debugging to be done around the world, and everyone is waiting for the bug to be solved.