react-native-carousel-control icon indicating copy to clipboard operation
react-native-carousel-control copied to clipboard
verified publisher icon machadogj

update component names

Open amkayondo opened this issue 6 years ago • 3 comments

What the PR does

  • Change componentWillReceiveProps to UNSAFE_componentWillReceiveProps
  • Change componentWillMount to UNSAFE_componentWillMount As for the names changes done by react updates https://reactjs.org/blog/2018/03/27/update-on-async-rendering.html

amkayondo avatar Nov 25 '19 20:11 amkayondo

Wouldn't the more correct way to do this be to actually change the method names and create a new version tag in git for this project? That way it wouldn't need to maintain old UNSAFE_ methods but still have a version that can be used if your project is running an old version of RN

dusan-turajlic avatar Jan 26 '20 17:01 dusan-turajlic

am using current react native version, so would you update the names because I love using this package😊

amkayondo avatar Jan 28 '20 09:01 amkayondo

I'm not a maintainer of this project I'm actually quite new to react-native. I was just wondering if there was a reason for just adding the UNSAFE_ instead of updating the class to have new methods. My comment was not a suggestion or advice it was just a question because I would like to know.

dusan-turajlic avatar Jan 28 '20 17:01 dusan-turajlic