Andrew Hershberger

Results 100 comments of Andrew Hershberger

Would it be acceptable to have those be separate callbacks? Keep the existing delegate method to handle when an annotation *is* tapped and add some other way to detect the...

@evil159 this is an interesting direction. I'd like to see it more fleshed out to account for checking and getting parameters and return values. Could you write up your proposed...

I've verified the behavior you describe. Here's a sample view controller that visualizes the issue: ``` final class DebugViewController: UIViewController { var mapView: MapView! var annotationManager: PolylineAnnotationManager! override public func...

Note that there are 2 methods with the prefix `coordinateBounds(` on MapboxMap: * `public func coordinateBounds(for camera: CameraOptions) -> CoordinateBounds` * Implemented in terms of `Map.coordinateBoundsForCamera` * [`public func coordinateBounds(for...

@akirmse can you clarify which methods you're referring to for both iOS and Android?

@akirmse would something like this work for your use case? ``` mapView.mapboxMap.coordinateBoundsUnwrapped(for: CameraOptions(cameraState: mapView.cameraState)) ``` (not to say that `coordinateBounds(for rect: CGRect)` doesn't have a bug — just offering a...

The 2D and 3D pucks are rendered into the MapView's metal view, and view annotations are just UIView subclasses on top of the metal view, so this is working as...

Thanks for the feedback. I agree with you — if your app doesn't need location, the Mapbox Maps SDK shouldn't be forcing you to add that key. The location component...

@evil159 I see 2 possibilities here (there could be others): 1. As mentioned above, avoid calling `Attribution.parse()` if `showsAttribution` is false. 2. Move the parsing off the main thread. This...

@devioustree thanks for the proposal. One clarifying question — are you trying to determine whether a layer is *currently visible* or just *get the value* of its `visibility` property. Note...