outset icon indicating copy to clipboard operation
outset copied to clipboard
verified publisher icon macadmins

Item runs should log as INFO as they did in Outset Python

Open jazzace opened this issue 1 year ago • 5 comments

Describe the bug In Outset Python, when an item was run (e.g., a script in login-once), the logs would show a line like: 2024-01-01 00:00:03 AM - INFO: Processing /usr/local/outset/login-every/login_script.sh

In this rewrite of Outset, this has been assigned as a DEBUG entry in the logs: 2024-01-01 00:00:04 DEBUG: Processing script /usr/local/outset/login-every/login_script.sh

Ideally, the behaviour in this implementation of Outset should match the previous behaviour.

To Reproduce

  1. Place a script in the login-once or login-every folder within /usr/local/outset/, set to executable by all users.
  2. Log in to an account so that Outset runs the item placed in the folder.
  3. Examine the logs (/usr/local/outset/logs/outset.log in this version of Outset, /Users//Library/Logs/outset.log in Outset Python).

Expected behaviour That the output should be the same or similar between this version of Outset and Outset Python.

Actual Behaviour Outset Python shows a line like: 2024-01-01 00:00:03 AM - INFO: Processing /usr/local/outset/login-every/login_script.sh This version of Outset only shows this information if verbose_logging is turned on in its preferences.

System Details:

  • OS: macOS 13.6.4, 17.4RC
  • Architecture: Intel and Apple Silicon M1 respectively
  • Version: 4.1.1.21918

jazzace avatar Mar 06 '24 23:03 jazzace

how does the change in commit https://github.com/macadmins/outset/commit/1c38f946653966d7fc39ef356eef58e26960d8f6 work with #44 where we now output everything to the log file regardless if debug s on or not?

I'm inclined to revert that change and selectively make .debug type log events to .info instead.

bartreardon avatar Mar 27 '24 06:03 bartreardon

Yes, the logs do fix the issue I raised, but as you suggested, I can only get verbose logs now. It would be good if you reverted to the previous behaviour now that Info items are the same as in Outset Python.

jazzace avatar Mar 27 '24 18:03 jazzace

yeah, I agree - regarding the level of info to debug, is there anything else currently marked as debug that you think should be in info?

bartreardon avatar Mar 27 '24 21:03 bartreardon

I don't think so. I was used to what the Python version gave me.

jazzace avatar Mar 27 '24 21:03 jazzace

this one ok to close? If there's any additional stuff you want being logged, LMK and we can chuck it into the 4.2.0 release

bartreardon avatar Nov 19 '24 05:11 bartreardon