Overrides not being added correctly

[RedClawx]

When adding an override the path is not getting recorded correctly into the preference file. I am following the instruction from https://github.com/macadmins/outset/wiki/ScriptOverrides. I am attempting to add two overrides. If the script is located in the "login-once" folder it gets added correctly. If the script is located in the "login-privileged-once" it does not get added correctly. The commands used are as follows:

sudo /usr/local/outset/outset --add-override /usr/local/outset/login-once/Remove_MS_Office_VL_User.sh
sudo /usr/local/outset/outset --add-override /usr/local/outset/login-privileged-once/Remove_MS_Office_VL_System.sh

When I look at the /Library/Preferences/io.macadmins.Outset.plist file the results are as follows:

<key>override_login_once</key>
<dict>
	<key>/usr/local/outset/login-once//usr/local/outset/login-privileged-once/Remove_MS_Office_VL_System.sh</key>
	<date>2023-11-16T19:25:46Z</date>
	<key>/usr/local/outset/login-once/Remove_MS_Office_VL_User.sh</key>
	<date>2023-11-16T19:26:01Z</date>
</dict>

[RedClawx]

I did more testing. It also appears that even if I have an override in a script not located in login-once it won't run if the script has already been ran. For example, if the io.macadmins.Outset.plist file is:

<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
	<key>ignored_users</key>
	<array/>
	<key>network_timeout</key>
	<integer>180</integer>
	<key>override_login_once</key>
	<dict>
		<key>/usr/local/outset/login-privileged-once/Remove_MS_Office_VL_System.sh</key>
		<date>2023-11-16T19:25:46Z</date>
		<key>/usr/local/outset/login-once/Remove_MS_Office_VL_User.sh</key>
		<date>2023-11-16T19:26:01Z</date>
	</dict>
	<key>run_once-brettdecarion</key>
	<dict>
		<key>/usr/local/outset/login-privileged-once/Remove_MS_Office_VL_System.sh</key>
		<date>2023-11-16T19:09:22Z</date>
	</dict>
	<key>wait_for_network</key>
	<true/>
</dict>
</plist>

The script located in login-privileged-once will not run again even though it's in the override_login_once section.

[bartreardon]

This was merged back in April but the issue was never closed. Will close now but if it's still an issue, please re-open.