react-native-sensitive-info icon indicating copy to clipboard operation
react-native-sensitive-info copied to clipboard

Feat/key rotation

Open mCodex opened this issue 3 months ago • 5 comments

This pull request introduces several significant improvements and new features to the Android core of the SensitiveInfo module, focusing on type safety, validation, and response consistency. It also includes some minor code style and configuration updates.

Android core improvements:

  • Introduced a type-safe Result<T> class in Result.kt to standardize error handling and composition of operations, along with extension functions for easier usage.
  • Added Extensions.kt with utility functions for working with Result, validation helpers, and keystore alias generation.
  • Added a central SensitiveInfoModule.kt for dependency configuration and storage validation logic, with clear guidance for future Hilt DI integration.
  • Implemented a ResponseBuilder interface and a standard implementation in ResponseBuilder.kt to ensure consistent, type-safe responses from native operations.
  • Added a StorageValidator interface and Android-specific implementation for robust input validation, enforcing key, value, and service constraints.

Metadata serialization and persistence:

  • Updated PersistedMetadata and PersistedEntry to include an alias field, ensuring alias information is serialized and deserialized correctly for storage metadata. [1] [2] [3] [4] [5] [6]

Code style and configuration:

  • Updated .prettierrc.js, babel.config.js, and app.plugin.js to enforce consistent code style (e.g., semicolons, tab width, quote style, trailing commas). [1] [2] [3]

mCodex avatar Nov 10 '25 17:11 mCodex

@mCodex I've opened a new pull request, #500, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot avatar Nov 10 '25 21:11 Copilot

@mCodex I've opened a new pull request, #501, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot avatar Nov 10 '25 21:11 Copilot

@mCodex I've opened a new pull request, #502, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot avatar Nov 10 '25 21:11 Copilot

@mCodex I've opened a new pull request, #503, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot avatar Nov 10 '25 21:11 Copilot

@mCodex I've opened a new pull request, #504, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot avatar Nov 10 '25 21:11 Copilot