commit icon indicating copy to clipboard operation
commit copied to clipboard

Initial running version on Windows

Open 66Leo66 opened this issue 2 years ago • 3 comments

Related: #5

Added compiler macros to isolate platform-specific code, allowing it to compile on Windows.

Working:

  • Basic function
  • Open commit window shortcut

Not working:

  • Window vibrancy (had no luck with mica/acrylic/blur - they just don't work)
  • Tiny black space on rounded corner
  • Open settings shortcut (no idea, maybe some broken cache on my system)

image

image

image

66Leo66 avatar Aug 15 '23 09:08 66Leo66

@66Leo66 Amazing work! I've added a build target for Windows on CI, so that anyone else following this (and me once I get back to my PC) can try this out.

I've also switched to using CommandOrControl for the keyboard shortcut, which should hopefully simplify the changes needed to the frontend (tho the module that displays the shortcut still needs some changes, namely displaying Ctrl instead of , and maybe the Windows key?).

I'm ok with disabling window vibrancy if you can't get it working (we'll have to do this in Linux too I think).

m1guelpf avatar Aug 16 '23 04:08 m1guelpf

Correct shortcut hint is being displayed in the tray menu now.

Settings shortcut only works when focusing commit's main window. Is this the intended behaviour?

66Leo66 avatar Aug 16 '23 04:08 66Leo66

Regarding window vibrancy: I have found the problem. Making frontend use background: transparetn is required to see the effects. However, since we are using https://github.com/tauri-apps/window-vibrancy, here's the situation:

  • Not on Linux: https://github.com/tauri-apps/window-vibrancy#platform-specific

  • blur is super laggy, don't use

  • arcylic feels okay on Win11 22H2 build 22621. Haven't tested on Win10 1903+ which is said to have bad performance. It reflect the color under the window. image

  • mica won't encounter performance issue, but it's Win11 only and it reflect the color of the wallpaper, so looks bad in some occurences. image image

GitHub
Make your windows vibrant. Contribute to tauri-apps/window-vibrancy development by creating an account on GitHub.
GitHub
Make your windows vibrant. Contribute to tauri-apps/window-vibrancy development by creating an account on GitHub.

66Leo66 avatar Aug 16 '23 04:08 66Leo66