Bigquery compatibility

Open erikdubbelboer opened this issue 5 years ago • 1 comments

Thanks for this library. I have made some big changes on my fork to make it compatible with BigQuery HLL functions. Which kinda makes it compatible with Google's zetasketch.

You can see the changes here: https://github.com/lytics/hll/compare/master...erikdubbelboer:master

The changes are major and change things like the way the hashes are encoded. This obviously breaks backwards compatibility for the Gob and JSON encodings.

I was wondering if you had any interest in merging this or if I should just continue maintaining my changes on my fork?

May 02 '20 11:05 erikdubbelboer

hi @erikdubbelboer - thanks for using this library!

As we currently use this library in production, and since your changes break backwards compatibility, I think we might want to keep your fork separate from master.

May 05 '20 17:05 timkaye11