Why does Gob encoder proxy to JSON

[harlow]

this was a little surprising: https://github.com/lytics/hll/blob/master/hll.go#L319-L322

Any reason for not using Gob?

[timkaye11]

Good question. I don't think there is a good reason for not using Gob (I think I was just being lazy when I wrote it). I'll work on correctly implementing GobEncode() and GobDecode()

[harlow]

Happy to submit a PR. Just wanted to check if there was a reason before doing so

On Tue, Jul 18, 2017 at 6:21 PM Tim Kaye [email protected] wrote:

Good question. I don't think there is a good reason for not using Gob (I think I was just being lazy when I wrote it). I'll work on correctly implementing GobEncode() and GobDecode()

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/lytics/hll/issues/10#issuecomment-316244616, or mute the thread https://github.com/notifications/unsubscribe-auth/AAtJxrK-oo58BHhTxM7ggwN7rEAAXOSnks5sPVn9gaJpZM4Ob2hf .

-- Harlow Ward [email protected] 805-450-5522