modules: fix cross-compilation

Open ffontaine opened this issue 4 years ago • 4 comments

Do not add -L$(libdir) to AM_LDFLAGS

[Retrieved from: https://git.buildroot.net/buildroot/tree/package/libfm/0001-modules-fix-cross-compilation.patch] Signed-off-by: Fabrice Fontaine [email protected]

Mar 15 '21 19:03 ffontaine

This change may cause problems with non-standard $(libdir), see 362d1925e18cb068ffc5ee501fdd4af3ac6dda96, or you think it was an old issue of libtool which is fixed nowadays?

Mar 16 '21 13:03 LStranger

I'll try to update the PR to drop -L$(libdir) only when cross-compiling to avoid this issue

Mar 16 '21 14:03 ffontaine

I believe you should simply add appropriate --libdir to your configure call for your cross-compiling recipe, the same way as it is usually done for cross-compiling everywhere.

Mar 16 '21 14:03 LStranger

Although it might be also possible that libtool issue is fixed, as I said, thus that line might be removed as you proposed. Let do it for 1.4.0 and see if anyone will report bugs.

Mar 16 '21 14:03 LStranger