Support getting io.popen results on file:close() on PUC-Rio Lua 5.1

Open hishamhm opened this issue 5 years ago • 2 comments

Jan 02 '21 16:01 hishamhm

Is there any thing in particular I should look out for when reviewing this PR?

Jan 20 '21 14:01 daurnimator

@daurnimator I followed the patterns used to load the string packing functions, and also tried to make it conditional to PUC-Rio Lua 5.1 only via ifdefs. The idea is that those changes should have no effect on other Lua versions.

Jan 21 '21 19:01 hishamhm

I've been pinged about this behavior in https://github.com/teal-language/tl/pull/687 — I'm inclined to merge this and push a release if nobody else has objections. @siffiejoe?

Sep 04 '23 20:09 hishamhm

no major objections from me

Sep 05 '23 02:09 daurnimator