keywind icon indicating copy to clipboard operation
keywind copied to clipboard

upgrade to v25.0.0 + aggregation of all my PRs

Open paulwer opened this issue 1 year ago • 14 comments

closes #62, #64, #47, #45, #89

special thanks to @waynemorphic who has helped us with some of the v25.0.0 upgrades

paulwer avatar Jun 19 '24 09:06 paulwer

@lukin ready for review

paulwer avatar Jun 19 '24 09:06 paulwer

Hey folks!

I really appreciate the effort here to generate email templates as well! How do I start utilizing this? I have a fork of keywind with all of my changes in it, should I merge this commit into my fork or just grab the files for the email theme because I dont want it to change what I have customized for my login theme already?

LeftoversTodayAppAdmin avatar Aug 22 '24 02:08 LeftoversTodayAppAdmin

Hi @LeftoversTodayAppAdmin, normally we would have to wait until its merged and you can then pull from origin to your fork.

@lukin do you have any kind of updates for us?

paulwer avatar Aug 22 '24 03:08 paulwer

@paulwer thanks for your huge effort!

I am also very interested in creating the mail theming via keywind and would be very happy if we had an ETA for it @lukin

JonathanSchndr avatar Sep 13 '24 09:09 JonathanSchndr

I am currently thinking about forking this repo, and develop it further seperatly, because there has not been any kind of responses for a long time now.

@lukin

paulwer avatar Sep 13 '24 13:09 paulwer

I apologize for the long wait for my response. You've done an incredible job and I'm happy with most of the changes. As I wrote earlier, I'm unsure about adding the Mailwind dependency, which is not actively supported. Maybe Maizzle is more suited to the project, but unfortunately, I don't have time to adapt that yet.

lukin avatar Sep 13 '24 14:09 lukin

Hmm, could we atleast create a PR for updates for keycloak v25? The PR scope could be smaller.

TafkaMax avatar Sep 13 '24 14:09 TafkaMax

Sure. It will be much easier to merge this without checking the other things. 🙂

lukin avatar Sep 13 '24 14:09 lukin

Great to hear that <3 I can create an PR without the mail part for now :)

paulwer avatar Sep 13 '24 15:09 paulwer

@lukin done, i removed the pr for emails from this pr.

feel free to reach out to me as you like

paulwer avatar Sep 16 '24 05:09 paulwer

@lukin i changed the code according to the review.

paulwer avatar Oct 07 '24 11:10 paulwer

@lukin any updates?

paulwer avatar Oct 30 '24 16:10 paulwer

I am really hoping the maintainer has some time to review the code. It is unfortunate that project seems at a weird state currently, where there are active forks, but the upstream is the blocker.. Probably will have to create my own fork if updates for newer KC versions are not merged by the end of the year. Just throwing it out there, but maybe it is a time to think about more maintainers?

TafkaMax avatar Nov 12 '24 12:11 TafkaMax

We descided to not support any future updates of this PR due to inactivity. You may want to checkout further informations why we did this here: #108

paulwer avatar Jan 13 '25 15:01 paulwer